-
Notifications
You must be signed in to change notification settings - Fork 8
feature: read force-command from client certificate #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
a4c999a to
dd119da
Compare
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 39f762e |
7149b30 to
13c8e82
Compare
13c8e82 to
39f762e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me but I found typos and may be we can test an invalid certificate ?
| // The file contains a publickey | ||
| pubKey, _, _, _, err := ssh.ParseAuthorizedKey(key) | ||
| if err == nil { | ||
| // The pubilckey is parsed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typos in publickey ;-)
| "", | ||
| " ", | ||
| []string{}, | ||
| }, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we test here a public key with an invalid certificate ?
| If the SSH server sets the 'SSH_USER_AUTH' environment variable (see | ||
| 'ExposeAuthInfo' in openssh's 'sshd_config'), 'sshproxy' uses it to get the | ||
| 'force-command' directive of the client's signed ssh public key. If a | ||
| 'force-command' is found, it is used as an argement to the 'ssh' command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo on argument ?
No description provided.